Mike Gerwitz

Activist for User Freedom

aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorMike Gerwitz <mike.gerwitz@rtspecialty.com>2019-10-24 16:22:31 -0400
committerMike Gerwitz <mike.gerwitz@rtspecialty.com>2019-10-29 13:36:55 -0400
commita23f2040ddfcb4b1fc93f8a004d9537a5ba15a10 (patch)
tree8d0e330d1eb4d7480f8d86a8ddccfd6575413590 /src
parent1ed8ad1cd716531a0ab573b61599a7baf8a96a9a (diff)
downloadliza-a23f2040ddfcb4b1fc93f8a004d9537a5ba15a10.tar.gz
liza-a23f2040ddfcb4b1fc93f8a004d9537a5ba15a10.tar.bz2
liza-a23f2040ddfcb4b1fc93f8a004d9537a5ba15a10.zip
RatingService: Remove unreachable error check
Diffstat (limited to 'src')
-rw-r--r--src/server/service/RatingService.ts26
1 files changed, 1 insertions, 25 deletions
diff --git a/src/server/service/RatingService.ts b/src/server/service/RatingService.ts
index 9338758..0bf4fc8 100644
--- a/src/server/service/RatingService.ts
+++ b/src/server/service/RatingService.ts
@@ -123,24 +123,6 @@ export class RatingService
}
- private _getProgramRater( program: Program, quote: ServerSideQuote )
- {
- var rater = this._rater_manager.byId( program.getId() );
-
- // if a rater could not be found, we can't do any rating
- if ( rater === null )
- {
- this._logger.log( this._logger.PRIORITY_ERROR,
- "Rating for quote %d (program %s) failed; missing module",
- quote.getId(),
- program.getId()
- );
- }
-
- return rater;
- }
-
-
/**
* Whether quote is still valid
*
@@ -181,13 +163,7 @@ export class RatingService
c: RequestCallback,
)
{
- var rater = this._getProgramRater( program, quote );
-
- if ( !rater )
- {
- this._server.sendError( request, 'Unable to perform rating.' );
- c();
- }
+ var rater = this._rater_manager.byId( program.getId() );
this._logger.log( this._logger.PRIORITY_INFO,
"Performing '%s' rating for quote #%s",