Mike Gerwitz

Activist for User Freedom

aboutsummaryrefslogtreecommitdiffstats
path: root/test
Commit message (Collapse)AuthorAgeFilesLines
* FieldStyler: Remove classes not added by #addClassMike Gerwitz2017-03-171-0/+98
| | | | | | | | | | This code assumed that no classes would be removed that were _not_ added by #addClass. Well, that's false. * src/ui/styler/FieldStyler.js (removeClass): Consider both spaces and boundary preceding class name. * test/ui/styler/FieldStylerTest.js: Add test case.
* ValidStateMonitor: Consider scalar diff to affect all indexesMike Gerwitz2017-03-171-0/+43
| | | | | | | | | | | Classifications often yield scalar results. Since those results are used directly in the diff, we have the situation where the expected diff format (an array) is not provided. Consistent with the rest of the system, we should consider a scalar to affect every index. * src/validate/ValidStateMonitor.js (_checkCauseFix): Consider scalar diffs to affect every index when checking for fixes. * test/validate/ValidStateMonitorTest.js: Add test.
* ValidStateMonitorTest: remove accidental `debugger'Mike Gerwitz2017-02-221-1/+0
| | | | | | Didn't mean for this to be committed. * test/validate/ValidStateMonitorTest.js: Remove `debugger'.
* DataApiManager: emit fieldLoaded after request completesMike Gerwitz2017-02-221-0/+83
| | | | | | | | | | | | The intent of this is to allow for clearing errors after fields load (e.g. a "field loading" message if the user attempts to continue past the step when a field hasn't yet finished loading). * src/dapi/DataApiManager.js (getApiData): Emit fieldLoaded after request completes. * test/dapi/DataApiManagerTest.js: Add test case. DEV-2299
* DataValidator: properly chain queueMike Gerwitz2017-02-211-18/+20
| | | | | | | | | This was not properly chain the promises---it was always chaining on the original _pending (so, the first request) and never clearing _pending after that point. * src/validate/DataValidator.js (_onceReady): Properly chain. * test/validate/DataValidatorTest.js: Updated test. Don't ask.
* StagingBucket: Do not process non-changesMike Gerwitz2017-02-201-0/+185
| | | | | | | | | | | | | | | | | Since changes trigger any event observers---which can be expensive---it is ideal to ignore sets that do not result in any changes to the bucket. This also resolves issues with systems that are confused by empty diffs. * src/bucket/StagingBucket.js (_hasChanged): Add method. (setValues): Use it. * test/bucket/StagingBucketTest.js: Add test case. DEV-2299
* DataValidator: Hold concurrent requestsMike Gerwitz2017-02-171-0/+36
| | | | | | | | | | | | | Since we maintain state (as a kluge for the time being to integrate with the rest of the system), we need to be careful to protect against concurrent requests that might mess with it before the original request is complete. * src/validate/DataValidator.js (validate, updateFailures): Hold concurrent requests. (_onceReady): Add method. * test/validate/DataValidatorTest.js: Add tests.
* Revert "DataValidator: Always clear store state"Mike Gerwitz2017-02-161-37/+0
| | | | | | | This breaks everything. :x This reverts commit e0c2e4dc861d523c40b2d35a242e48b8b7c99662, reversing changes made to e610372c8443ba5c5e73ed0791e642d82772d5cd.
* DataValidatorTest: Extract boilerplate instantiation (cleanup)Mike Gerwitz2017-02-161-51/+46
| | | | | | | | Tidy up a little bit; this thing is a mess and hard to work with. * test/validate/DataValidatorTest (createStubs): Add function. Use it.
* Add missing #updateFailures testMike Gerwitz2017-02-161-0/+52
| | | | | | Not sure how this was missing...! * test/validate/DataValidatorTest.js: Add test.
* DataValidator: Queue validations when incompleteMike Gerwitz2017-02-161-0/+65
| | | | | | | | | * src/validate/DataValidator.js (validate): If a validation is ongoing, queue requests. * test/validate/DataValidatorTest.js: Add test. DEV-2299
* DataValidator: Always clear store stateMike Gerwitz2017-02-131-0/+39
| | | | | | | | | | | | | In practice, not clearing the store and allowing it to use previous state has the effect of instantly "fixing" failures if there happens to be more than one validation call. This was a log of debugging for a one-line change. * src/validate/DataValidator.js (_populateStore): Always clear store. * test/validate/DataValidatorTest.js: Add test. DEV-2299
* FieldVisibilityEventHandler: use new DataValidator APIMike Gerwitz2017-02-091-3/+4
| | | | | | | | | | | | | | I updated DataValidator but never updated the caller. Damnit. It's an unfortunate side-effect of dynamic, loosely typed languages and mitigating it requires what should be boilerplate functional tests (in this case---functional tests are useful for many other integration aspects). * src/event/FieldVisibilityEventHandler.js (handle): Use updated DataValidator#clearFailures API, which has a different descriptor format. * test/event/FieldVisibilityEventHandlerTest.js: Update test.
* FieldVisibilityEventHandler: Add classMike Gerwitz2017-02-081-0/+145
| | | | | | | | This extracts code from internal lovullo repo rating-fw (originally Client#_hideFields), 5d4019f1973f9271f4b1bd24ce1f55b56ccda09e. * src/event/FieldVisibilityEventHandler.js: Add class. * test/event/FieldVisibilityEventHandlerTest.js: Add test case.
* DataValidator, ValidStateMonitor: Add #clearFailures argumentMike Gerwitz2017-02-082-5/+56
| | | | | | | | | | | | | | This allows clearing only the specified failures. * src/validate/ValidStateMonitor.js (clearFailures): Add `fields' argument. Make method more concise. (_fixFailure): Handle clearing `_failures' record. * src/validate/DataValidator.js (clearFailures): Add `fields' argument. * test/validate/ValidStateMonitorTest.js: Add test. * test/validate/DataValidatorTest.js: Add test.
* DataValidator, ValidStateMonitor: Add #clearFailuresMike Gerwitz2017-02-022-0/+53
| | | | | | | | * src/validate/DataValidator.js (clearFailures): Add public method. * test/validate/DataValidatorTest.js: Add #clearFailures test. * src/validate/ValidStateMonitor.js (clearFailures): Add public method. * test/validate/ValidStateMonitorTest.js: Add #clearFailures test.
* system.client: working data.diffStoreMike Gerwitz2017-01-301-4/+33
| | | | | | | * src/system/client.js (data.diffStore): Compose all stores. * test/system/clientTest.js: Update test case. DEV-2296
* DataValidator: accept classification resultsMike Gerwitz2017-01-301-8/+66
| | | | | | | | | | | | | * src/validate/DataValidator.js (validate): New `classes' parameter. API BC break from previous commits. (populateStore, updateFailures): Generalize methods. * test/validate/DataValidatorTest.js: Add associated test. Refactor existing tests to adhere to new API/expectations. DEV-2206
* ValidStateMonitor: handle empty diff on past failureMike Gerwitz2017-01-301-0/+19
| | | | | | | | | | | | See the description in the test case. This is a bug fix. * src/validate/ValidStateMonitor.js (_checkCauseFix): Do not consider an empty diff on a past failure to be a fix. * test/validate/ValidStateMonitorTest.js: Add test. DEV-2296
* Add DiffStoreMike Gerwitz2017-01-301-0/+235
| | | | | | | * src/store/DiffStore.js: Add class. * test/store/DiffStoreTest.js: Add test case. DEV-2296
* Store#clear to return selfMike Gerwitz2017-01-301-0/+10
| | | | | | | | * src/store/MemoryStore.js (clear): Promise resolve to self. * src/store/Store.js (clear): Update docblock. * test/store/MemoryStoreTest.js: Update test case accordingly. DEV-2296
* Add PatternProxy Store traitMike Gerwitz2017-01-301-0/+164
| | | | | | | | | | Life is so much less miserable now that the project is supporting ES6. * src/store/PatternProxy.js: Add trait. * src/store/StorePatternError.js: Add Error. * test/store/PatternProxyTest.js: Add test case. DEV-2296
* Store#add to return selfMike Gerwitz2017-01-291-5/+4
| | | | | | | | | | | | | | | This allows for Promise chaining (and consequently temporary classes, great for testing). * src/store/MemoryStore.js (add): Resolve promise to self. Modify docblock. * src/store/Store.js (add): Modify docblock. * src/store/Cascading.js (add): Modify docblock. * test/store/MemoryStoreTest.js: Modify test accordingly. DEV-2296
* Began system/ with clientMike Gerwitz2017-01-291-0/+46
| | | | | | | | | | | | | This will contain various factories (compounded in some cases) to instantiate various parts of a coherent system. It aims to replace (as one of many pieces) the ClientDependencyFactory that's referenced in the code, which is still part of rating-fw (internal LoVullo repo from which liza is being liberated). * src/system/client.js: Add module. * test/system/clientTest.js: Add functional test case. DEV-2296
* Integrate Store into DataValidator, ValidStateMonitorMike Gerwitz2017-01-292-262/+396
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ValidStateMonitor now uses a Store in place of the original primitive object-based diff format. The original format is translated by DataValidator. The code is in a transitional state, and considering the amount of time we spend on various areas of this project, will likely stay this way for a while. * src/validate/DataValidator.js (__construct): Accept Store factory parameter. (_store_factory): Add field. (_createStores): Add method. (_validate): Handle Store. (updateFailures): Add method. (_populateStore): Add method. * test/validate/DataValidatorTest.js: Add tests. * src/validate/ValidStateMonitor.js (update): Enforce Store diff. Wait to process failures until fixes are calculated. (_checkFailureFix): Handle asynchronous, Promise-based diff. (_checkCauseFix): Extract logic from _checkCauseFix. * test/validate/ValidStateMonitorTest.js: Modify test cases to be Promise-based and handle async calls where appropriate. That was a friggin' expensive mess. DEV-2296
* Add DataValidatorMike Gerwitz2017-01-271-0/+183
| | | | | | | | | | This extracts some gross code from Client in the rating-fw repo, which is responsible for gluing change validations together. * src/validate/DataValidator.js: Add class. * test/validate/DataValidatorTest.js: Add test case. DEV-2296
* ValidStateMonitor#update return PromiseMike Gerwitz2017-01-271-52/+96
| | | | | | | | | | Stepping stone to async. fix checks. * src/validate/ValidStateMonitor.js (update, detectFixes, _checkFailureFix): Return Promise. * test/validate/ValidStateMonitorTest.js: Update to use promises. DEV-2296
* Test to ensure Cascading does not clear selfMike Gerwitz2017-01-041-0/+14
| | | | | * test/store/CascadingTest.js: Test that Cascading store does not clear itself.
* Add StoreMissErrorMike Gerwitz2017-01-041-1/+2
| | | | | | | | Nice and trivial with the new easejs transparent error subtyping! * src/store/StoreMissError.js: Add error class. * src/store/MemoryStore.js (get): Use it. * test/store/MemoryStoreTest.js (#get): Modify test to expect type.
* Add MissLookup traitMike Gerwitz2017-01-041-0/+163
| | | | | * src/store/MissLookup.js: Add trait. * test/store/MissLookupTest.js: Add test case.
* Make {,Memory}Store asynchronousMike Gerwitz2017-01-042-37/+98
| | | | | This isn't terribly useful as a general-purpose cache if it can't handle async requests.
* Add store.CascadingMike Gerwitz2017-01-031-0/+77
| | | | | * src/store/Cascading.js: Add trait. * test/store/CascadingTest.js: Add test case.
* Add {,Memory}StoreMike Gerwitz2017-01-031-0/+185
| | | | | | * src/store/Store.js: Add interface. * src/store/MemoryStore.js: Add class. * test/store/MemoryStoreTest.js: Add test case.
* Replace Currency formatter with StringFormatMike Gerwitz2016-12-012-60/+115
| | | | | | | | | | This is a much more general solution. * src/validate/formatter/Currency.js: Remove trait. * test/validate/formatter/CurrencyTest.js: Remove test case. * src/validate/formatter/StringFormat.js: Add trait. * test/validate/formatter/StringFormatTest.js: Add test case.
* Validate correct Number formatMike Gerwitz2016-12-011-0/+8
| | | | | | | * src/validate/formatter/Number.js (parse): Validate number format. * test/validate/formatter/NumberTest.js: Modify accordingly.
* Add scale to Number formatterMike Gerwitz2016-12-011-0/+43
| | | | | | | | | | * src/validate/formatter/Number.js (__mixin): Add mixin ctor. (parse): Handle scale. (styleNumber): Handle scale. (scale, split): Add methods. * test/validate/formatter/NumberTest.js: Modified accordingly.
* Add Currency formatterMike Gerwitz2016-11-281-0/+60
| | | | | * src/validate/formatter/Currency.js: Add trait. * test/validate/formatter/CurrencyTest.js: Add test case.
* Correct and test GeneralStepUi#scrollToMike Gerwitz2016-08-051-7/+248
| | | | | | | | * src/ui/step/GeneralStepUi.js (scrollTo): Will now abort after each error rather than falling through. Visibility error message will now show field index. * test/ui/step/GeneralStepUiTest.js: Added respective test cases
* Add MultiDimension formatterMike Gerwitz2016-06-281-0/+109
| | | | | * src/validate/formatter/MultiDimension.js: Added * test/validate/formatter/MultiDimensionTest.js: Added
* Add accept/reject stylerMike Gerwitz2016-06-281-0/+93
| | | | | * src/validate/formatter/AcceptReject.js: Added. * test/validate/formatter/AcceptRejectTest.js: Added.
* Add Limit formatterMike Gerwitz2016-06-271-0/+68
| | | | | * src/validate/formatter/insurance/Limit.js: Added * test/validate/formatter/insurance/LimitTest.js: Added
* Add Number formatterMike Gerwitz2016-06-271-0/+50
| | | | | * src/validate/formatter/Number.js: Added * test/validate/formatter/NumberTest.js: Added
* Add MultiDelimited formatter traitMike Gerwitz2016-06-271-0/+71
| | | | | | | | This will simplify, through composition, a number of other validator-formatters. * src/validate/formatter/MultiDelimited.js: Added * test/validate/formatter/MultiDelimitedTest.js: Added
* UnorderedList{Formatter=>} now a traitMike Gerwitz2016-06-241-5/+16
| | | | | | | | | | | This adds a great deal of flexibility through composition via trait stacking. * src/validate/formatter/UnorderedList.js: Renamed from UnorderedListFormatter; now a trait. * test/validate/formatter/UnorderedListTest.js: Renamed from UnorderedListFormatterTest and adjusted to instantiate trait.
* Add mixin testing to common vformat functionsMike Gerwitz2016-06-231-1/+46
| | | | * test/validate/formatter/common.js (testMixin): Added.
* Add EchoFormatterMike Gerwitz2016-06-231-0/+65
| | | | | * src/validate/formatter/EchoFormatter.js: Added. * test/validate/formatter/EchoFormatterTest.js: Added.
* Liberated UnorderedListFormatterMike Gerwitz2016-06-231-0/+141
| | | | | | | | These have been refacored from the original: rather than abusing what is now the PatternFormatter, it is now its own class. * src/validate/formatter/UnorderedListFormatter.js: Added. * test/validate/formatter/UnorderedListFormatterTest.js: Added.
* Liberate common validator-formatter test functionMike Gerwitz2016-06-231-0/+95
| | | | | | | This has been modified from the original to use Chai instead of the `assert' module. * test/validate/formatter/common.js: Added.
* VFormat => PatternFormatter with added interfaceMike Gerwitz2016-06-221-4/+13
| | | | | | | * src/validate/ValidatorFormatter.js: Interface added. * src/validate/formatter/PatternFormatter.js: Renamed from ../VFormat.js. * test/validate/formatter/PatternFormatterTest.js: Renamed from ../VFormatTest.js.
* Liberate VFormatMike Gerwitz2016-06-221-0/+115
| | | | | | | This will likely undergo some refactoring. * src/validate/VFormat.js: Added. * test/validate/VFormatTest.js: Added.