[DEV-7134] Remove unnecessary node replacement

The node was being replaced before we were catching errors properly. Now
that they are propagated, we should not need the replacement.

1 files changed, 4 insertions, 20 deletions

diff --git a/tamer/src/ir/asg/base.rs b/tamer/src/ir/asg/base.rs
index a50fe8b..5cedf83 100644
--- a/tamer/src/ir/asg/base.rs
+++ b/tamer/src/ir/asg/base.rs
@@ -250,15 +250,10 @@ where
                 );
                 Ok(ty)
             }
-            _ => {
-                let err = Err(AsgError::BadFragmentDest(format!(
-                    "identifier is not a Object::Ident): {:?}",
-                    ty,
-                )));
-
-                node.replace(ty);
-                err
-            }
+            _ => Err(AsgError::BadFragmentDest(format!(
+                "identifier is not a Object::Ident): {:?}",
+                ty,
+            ))),
         }?;
 
         node.replace(result);
@@ -645,17 +640,6 @@ mod test {
             _ => panic!("expected AsgError::BadFragmentDest: {:?}", err),
         }
 
-        // Make sure we didn't leave the node in an inconsistent state
-        assert_eq!(
-            Some(&Object::IdentFragment(
-                &sym,
-                IdentKind::Meta,
-                Default::default(),
-                fragment
-            )),
-            sut.get(node)
-        );
-
         Ok(())
     }